From fb6a6bb19896cd3094fb19d6e510c3dec0c1cc7c Mon Sep 17 00:00:00 2001 From: Thomas Hodnemyr Date: Sun, 18 Sep 2022 00:39:26 +0200 Subject: [PATCH] OptimizedCode in Camera Controller --- Assets/Scripts/CameraController.cs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Assets/Scripts/CameraController.cs b/Assets/Scripts/CameraController.cs index 031ec15..191aa00 100644 --- a/Assets/Scripts/CameraController.cs +++ b/Assets/Scripts/CameraController.cs @@ -9,6 +9,7 @@ namespace AsteroidGame private CameraControllActions cameraActions; private InputAction movement; private Transform cameraTransform; + private Camera cameraReference; // Horizontal Movement [SerializeField] @@ -53,7 +54,9 @@ namespace AsteroidGame private void Awake() { cameraActions = new CameraControllActions(); - cameraTransform = this.GetComponentInChildren().transform; + + cameraReference = this.GetComponentInChildren(); + cameraTransform = cameraReference.transform; } private void OnEnable() @@ -130,7 +133,7 @@ namespace AsteroidGame if (targetPosition.sqrMagnitude > 0.1f) { speed = Mathf.Lerp(speed, maxSpeed, Time.deltaTime * acceleration); - transform.position += targetPosition * speed * Time.deltaTime; + transform.position += speed * Time.deltaTime * targetPosition; } else { @@ -195,7 +198,7 @@ namespace AsteroidGame if (!Mouse.current.rightButton.isPressed) { return; } - Ray ray = Camera.main.ScreenPointToRay(Mouse.current.position.ReadValue()); + Ray ray = cameraReference.ScreenPointToRay(Mouse.current.position.ReadValue()); if (cameraPlane.Raycast(ray,out float distance)) { if (Mouse.current.rightButton.wasPressedThisFrame)